other: take ownership of config and matches when building App #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 31.54% 31.57% +0.02%
==========================================
Files 97 97
Lines 16498 16503 +5
==========================================
+ Hits 5205 5210 +5
Misses 11293 11293
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ClementTsang
force-pushed
the
take-config-and-matches-ownership
branch
from
87075d1
to
2a17f0d
Compare
The clap matches/config struct was taken in as a reference when building the App structure. However, we do not need to keep these around after this, so we can instead take ownership of the match/config and drop it after to save a bit of memory.
ClementTsang
force-pushed
the
take-config-and-matches-ownership
branch
from
2a17f0d
to
9f22628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
The clap matches/config struct was taken in as a reference when building the App structure. However, we do not need to keep these around after this, so we can instead take ownership of the match/config and drop it after to save a bit of memory.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)